Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special case NaN in setter #912

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

Rayzhangzhang
Copy link
Contributor

I suppose there is a bug in setter about ‘NaN’ special case.

@netlify
Copy link

netlify bot commented Feb 26, 2022

✔️ Deploy Preview for quizzical-lovelace-dcbd6a canceled.

🔨 Explore the source changes: a2b1717

🔍 Inspect the deploy log: https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/622db8ed8c9b5e00084783d2

@mweststrate
Copy link
Collaborator

would you mind adding a unit test to demonstrate the problem solved by this change?

@Rayzhangzhang
Copy link
Contributor Author

would you mind adding a unit test to demonstrate the problem solved by this change?

Thanks for replay, the unit test has been added.

@mweststrate mweststrate merged commit 5721bb7 into immerjs:master Oct 22, 2022
@unional
Copy link
Contributor

unional commented Oct 30, 2022

Hi, @Rayzhangzhang, @mweststrate, this PR cause 8 test failures. thx

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023

🎉 This PR is included in version 9.0.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants