New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first pass at persistent anchors #75
Conversation
More work needs to be done to describe how the UUIDs are stored by the UA. |
Thanks @cabanier I am looking forward to this |
Took a quick pass now. A couple of questions:
|
I was planning on extending this PR; otherwise the spec would be in an incomplete state.
I would prefer if we keep the same descriptor and just fail if the UA doesn't support persistence. |
Extending the PR sounds good (and it'll be easier to see all the changes needed for persistent anchors).
Sounds good to me! |
Have a conflict for today's call. However, I took a quick look through this PR and the general approach looks good to me! It should be straightforward to implement this on top of the XR_MSFT_spatial_anchor_persistence OpenXR extension. The major design point worth talking through is whether it's more "webby" for this API to return the persistent anchor keys upon the request, or to accept the desired key from the app. Microsoft's underlying XR_MSFT_spatial_anchor_persistence OpenXR extension accepts a key from the app, though I don't feel strongly about that approach - it seems OK to require the app to tie the UA-generated key to some meaning in its own storage. The other thing I would be sure to clarify when you write up prose is that no promises are made that this key will be usable on any other device - this API is about local-device anchor persistence rather than cross-device anchor sharing. For privacy reasons, we may actually want the line in the spec that mentions that the keys returned must be unique per-domain to also mention that they also must be unique per-device. |
Good point! I'll add that to the spec. |
/tpac discuss persistent anchor proposal |
Looks good to me, w/ minor nitpicks that can be addressed later. |
/agenda https://cabanier.github.io/anchors/
Preview | Diff