Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update the WebXR example with latest polyfill for ML Helio. #14

Closed
yhuang-ml opened this issue Dec 10, 2019 · 4 comments
Closed

Comments

@yhuang-ml
Copy link

The demo of VR and AR is using outdated HelioWebXRPolyfill.js file, which causes issues when view this example in XR mode on ML Helio.
Is there anyway to contact the author of this example to update the website with the latest Helio WebXR polyfill, which is already in the latest three.js repo: https://github.com/mrdoob/three.js/blob/dev/examples/js/vr/HelioWebXRPolyfill.js so that it works on Helio as well?

@AdaRoseCannon
Copy link
Member

Probably it would be best to submit a PR to three.js itself to get that updated.

@yhuang-ml
Copy link
Author

Is this example from three.js repo? three.js repo already has the latest HelioWebXRPolyfill.js, but the example includes an old copy of it.

@AdaRoseCannon
Copy link
Member

AdaRoseCannon commented Dec 10, 2019 via email

@yhuang-ml
Copy link
Author

I see. I'll update it to that repo directly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants