Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow higher quality filtering #275

Closed
cabanier opened this issue Nov 30, 2021 · 6 comments · Fixed by #302
Closed

Allow higher quality filtering #275

cabanier opened this issue Nov 30, 2021 · 6 comments · Fixed by #302

Comments

@cabanier
Copy link
Member

We've seen that a very common use case for layers is the display of documents or UI with text.
Currently, layers are tuned for performance but they have the ability to turn on extra filtering which improves text readability. See https://www.facebook.com/RealityLabs/videos/1021802275341764/ around the 14 minute mark.

Should we make this available for WebXR Layers? I envision that this could be an optional feature that UAs can ignore.

/agenda should we allow higher quality filtering?

@probot-label probot-label bot added the agenda label Nov 30, 2021
@toji
Copy link
Member

toji commented Dec 7, 2021

I want to look into the mechanics of how this is set with OpenXR a bit more, but at a high level I don't object to this. Seems like a sensible knob for developers to make performance/readability tradeoffs for a challenging case (text).

I'll also mention that I'm a little reluctant to pile too many knobs onto layers, especially in an environment where we don't have a practical way of validating that they'll be supported by more than one vendor. It's hard in this case, though, because we're handing off so much control of how it's rendering to the compositor, so maybe it's inevitable that our list of settings will grow.

@cabanier
Copy link
Member Author

cabanier commented Dec 8, 2021

I want to look into the mechanics of how this is set with OpenXR a bit more, but at a high level I don't object to this. Seems like a sensible knob for developers to make performance/readability tradeoffs for a challenging case (text).

It's going to be part of the structure that lets you control the sampler state of the swapchain. I'm unsure if we need the same level of control in WebXR; maybe it's enough to specify linear or bicubic at layer creation time.

@cabanier
Copy link
Member Author

cabanier commented Dec 8, 2021

This could also tie into specifying the color profile of the swapchain. (I know @Artyom17 filed an issue on that but I can't find it)

@cabanier
Copy link
Member Author

cabanier commented Dec 8, 2021

Actually, it might make more sense to set it at runtime. Maybe it could be a parameter on XRCompositionLayer.

@Yonet Yonet removed the agenda label Dec 14, 2021
@cabanier
Copy link
Member Author

cabanier commented Feb 5, 2023

Meta added support to enhance the quality of composition layers (this includes projection).
I don't remember where we left this but when I turned this on as an experiment, video layers were visibly improved

/agenda add support to layers for different quality settings

@probot-label probot-label bot added the agenda label Feb 5, 2023
@AdaRoseCannon
Copy link
Member

Removing label, because it was discussed at the last meeting, if this is in error or more discussion is needed please reuse '/agenda'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants