Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pixel, S7 Edge, 6s+, clean up iOS doubles #183

Merged
merged 1 commit into from Jan 5, 2017
Merged

Add Pixel, S7 Edge, 6s+, clean up iOS doubles #183

merged 1 commit into from Jan 5, 2017

Conversation

thoragio
Copy link
Contributor

@thoragio thoragio commented Jan 4, 2017

Added device settings for:

  • Samsung S7 Edge
  • Motorola Moto G4
  • Google Pixel
  • iPhone 6s+

These settings have been confirmed as working on various GH issue threads in the WebVR boilerplate and A-Frame repos.

Also, removed duplicate entries for iOS devices.

For some background see:
aframevr/aframe#2008
aframevr/aframe#2117

This PR is focused on issue 2117 in particular.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@thoragio
Copy link
Contributor Author

thoragio commented Jan 4, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants