Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention generic-hand-select #30

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented Jul 23, 2020

Pairs with immersive-web/webxr-input-profiles#170

We can change this if there are ever hand input sources that do not support select. For now it doesn't matter too much.

r? @cabanier


Preview | Diff

index.bs Outdated
@@ -128,6 +129,8 @@ Physical Hand Input Sources {#physical-hand}

An {{XRInputSource}} is a <dfn>physical hand input source</dfn> if it tracks a physical hand. A [=physical hand input sources=] <dfn>supports hand tracking</dfn> if it supports reporting the poses of one or more [=skeleton joint=]s defined in this specification.

[=Physical hand input sources=] SHOULD include the [=XRInputSource/input profile name=] of "generic-hand-select" in their {{XRInputSource/profile}}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be a MUST?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, I was being cautious for now. I'll change it.

@Manishearth
Copy link
Contributor Author

input profile merged

@Manishearth Manishearth merged commit 6ba1ee1 into immersive-web:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants