New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create generic-hand-select-grasp.json #185
Conversation
Tabs to spaces
Removed overlapping squeeze prefix
…lect-overlapping-squeeze.json Name change to match overlapping squeeze
…eric-hand-select-grasp.json overlapping-squeeze -> grasp
So do y'all intend to trigger squeeze events when this profile is being used, or will this just be signalled as a toggling of the "grasp" button? Because if you trigger squeeze events that overlap with select, you're liable to have lots of bugs on content that is written for devices with independent select/squeeze events (see immersive-web/webxr#997) |
@Manishearth the idea for this one is to NOT trigger squeeze events. I renamed squeeze to grasp in this case to disambiguate that a bit. I'm not 100% on what the naming should be though so I think this is worthy to discuss. |
Ah, that works great then. I'm r+ on this, and we may want to mention this profile in the hand input repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toji should r+ too
@toji How's it looking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposing the generic-hand-select-grasp input profile. This input profile is appropriate for hand tracked systems which expose select and squeeze gestures in which the squeeze gesture may overlap with the select gesture and does not fire squeeze events.