Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Changed requestPresent to accept a sequence of VRLayers #36

Closed
cvan opened this issue Jun 1, 2016 · 6 comments
Closed

[CLOSED] Changed requestPresent to accept a sequence of VRLayers #36

cvan opened this issue Jun 1, 2016 · 6 comments

Comments

@cvan
Copy link
Contributor

cvan commented Jun 1, 2016

Issue by toji
Thursday Mar 31, 2016 at 17:29 GMT
Originally opened as MozillaReality/webvr-spec#28


Also added maxLayers capability. As per conversations with @vvuk. Still restricts the v1 spec to only accepting a single layer, but makes future changes to allows for more complex compositing more sensible.


toji included the following code: https://github.com/MozVR/webvr-spec/pull/28/commits

@cvan
Copy link
Contributor Author

cvan commented Jun 1, 2016

Comment by toji
Thursday Mar 31, 2016 at 17:55 GMT


If this change were to go into effect I would probably keep the non-array variant of the function in Chrome's experimental builds for a bit and have them print a deprecation warning to the console when used, just so any 1.0 compatible content people have built doesn't immediately fail.

@cvan
Copy link
Contributor Author

cvan commented Jun 1, 2016

Comment by cvan
Friday Apr 01, 2016 at 01:39 GMT


needs rebase

@cvan
Copy link
Contributor Author

cvan commented Jun 1, 2016

Comment by toji
Saturday Apr 02, 2016 at 00:01 GMT


Rebased and addressed @cvan's comments. Thanks!

@cvan
Copy link
Contributor Author

cvan commented Jun 1, 2016

Comment by cvan
Saturday Apr 02, 2016 at 00:47 GMT


this looks great. r+ and that's no joke 👍

@cvan
Copy link
Contributor Author

cvan commented Jun 1, 2016

Comment by mkeblx
Thursday Apr 14, 2016 at 21:48 GMT


Saw this in IDL.
https://github.com/MozVR/webvr-spec/blob/master/index.idl#L44

@cvan
Copy link
Contributor Author

cvan commented Jun 1, 2016

Comment by cvan
Thursday Apr 14, 2016 at 23:37 GMT


oh, good catch. gotta fix that.

@cvan cvan closed this as completed Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant