Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRPresentationContext should be a dictionary #449

Closed
Manishearth opened this issue Dec 19, 2018 · 1 comment · Fixed by #501
Closed

XRPresentationContext should be a dictionary #449

Manishearth opened this issue Dec 19, 2018 · 1 comment · Fixed by #501
Labels
spec bug Inconsistencies in spec
Milestone
April 2019

Comments

@Manishearth
Copy link
Contributor

In the current version of the spec there's no way to actually present inline webxr content to a canvas, since there's no way to construct XRPresentationContext.

The spec should instead use a dictionary for outputContext in XRSessionCreationOptions (or directly have a canvas field there)
@NellWaliczek NellWaliczek added this to the FPWD milestone Jan 4, 2019
@NellWaliczek
Copy link
Member

The mechanism for creating an XRPresentationContext is demonstrated in the sample code in this section: https://github.com/immersive-web/webxr/blob/master/explainer.md#rendering-to-the-page

It appears that the corroborating spec text is missing.

@NellWaliczek NellWaliczek assigned NellWaliczek and toji and unassigned toji Jan 4, 2019
@cwilso cwilso modified the milestones: FPWD, Next Working Draft Jan 9, 2019
@NellWaliczek NellWaliczek added the spec bug Inconsistencies in spec label Jan 17, 2019
@Manishearth Manishearth mentioned this issue Jan 30, 2019
Merged
@toji toji closed this as completed in #501 Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec bug Inconsistencies in spec
Projects
None yet
Milestone
April 2019
Development

Successfully merging a pull request may close this issue.

Spec XRPresentationContext creation Manishearth/webxr
4 participants
@cwilso @toji @Manishearth @NellWaliczek