Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update origin offset handling in the explainer. #634

Closed
toji opened this issue May 9, 2019 · 0 comments · Fixed by #642
Closed

Update origin offset handling in the explainer. #634

toji opened this issue May 9, 2019 · 0 comments · Fixed by #642
Assignees
@toji
Labels
fixed by pending PR A PR that is in review will resolve this issue. help wanted This is a good issue for anyone to pick up and work on filing a PR for.
Milestone
May 2019

Comments

@toji
Copy link
Member

toji commented May 9, 2019

When we made the recent change from the originOffset attribute to the getOffsetReferenceSpace() method (#580) the explainer missed getting the new definitions. Let's do a pass over it to make sure the origin offset language is consistent with the spec.
@toji toji mentioned this issue May 9, 2019
Merged
@toji toji added the help wanted This is a good issue for anyone to pick up and work on filing a PR for. label May 10, 2019
@cwilso cwilso added this to the May 2019 milestone May 13, 2019
@cwilso cwilso assigned cwilso and toji and unassigned cwilso May 13, 2019
@toji toji mentioned this issue May 14, 2019
Merged
@toji toji added the fixed by pending PR A PR that is in review will resolve this issue. label May 15, 2019
@toji toji closed this as completed in #642 May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toji toji

Labels
fixed by pending PR A PR that is in review will resolve this issue. help wanted This is a good issue for anyone to pick up and work on filing a PR for.
Projects
None yet
Milestone
May 2019
Development

Successfully merging a pull request may close this issue.

Updated the explainer with new origin offset mechanics. immersive-web/webxr
2 participants
@cwilso @toji