Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing "list of pending render states" with "pending render state" #678

Closed
ddorwin opened this issue May 31, 2019 · 2 comments · Fixed by #701
Closed

Consider replacing "list of pending render states" with "pending render state" #678

ddorwin opened this issue May 31, 2019 · 2 comments · Fixed by #701
Assignees
Labels
help wanted This is a good issue for anyone to pick up and work on filing a PR for.
Milestone

Comments

@ddorwin
Copy link
Contributor

ddorwin commented May 31, 2019

Having a list just adds a little more complexity and potential confusion for the user, so it'd be nice to collapse it if possible.

It seems that updateRenderState() could maintain a single nullable "pending render state" that gets updated (as in step 5 of https://immersive-web.github.io/webxr/#apply-pending-render-states) and when not null gets applied in https://immersive-web.github.io/webxr/#apply-pending-render-states.

@cwilso cwilso added this to the July 2019 milestone Jun 10, 2019
@cwilso cwilso added the help wanted This is a good issue for anyone to pick up and work on filing a PR for. label Jun 10, 2019
@toji
Copy link
Member

toji commented Jun 10, 2019

Editors talked about this and remembered that the current design was due to a previous design that had us resolving a promise every time a change was applied. That's not longer a concern, however, so this simplification is fine.

@Manishearth
Copy link
Contributor

#701

@toji toji closed this as completed in #701 Jun 14, 2019
@toji toji modified the milestones: July 2019, June 2019 Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted This is a good issue for anyone to pick up and work on filing a PR for.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants