Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing XRWebGLLayer's context attribute #679

Closed
ddorwin opened this issue May 31, 2019 · 5 comments
Closed

Consider removing XRWebGLLayer's context attribute #679

ddorwin opened this issue May 31, 2019 · 5 comments
Labels
fixed by pending PR A PR that is in review will resolve this issue. help wanted This is a good issue for anyone to pick up and work on filing a PR for. potential breaking change Issues that may affect the core design structure.
Milestone
June 2019

Comments

@ddorwin
Copy link
Contributor

ddorwin commented May 31, 2019

XRWebGLLayer's context attribute only reflects the value that was passed into the object's constructor. As in #513, we should consider removing this value.

In this case, removing this unnecessary attribute may also simplify future extensions to other types of layers (at least for WebGPU). See #268 (comment).
@ddorwin ddorwin mentioned this issue May 31, 2019
Closed
@cwilso cwilso added this to the June 2019 milestone Jun 10, 2019
@cwilso cwilso added potential breaking change Issues that may affect the core design structure. help wanted This is a good issue for anyone to pick up and work on filing a PR for. labels Jun 10, 2019
@ddorwin
Copy link
Contributor Author

ddorwin commented Jun 12, 2019

Does the help wanted label indicate this is waiting for a PR? It's not clear whether a decision was made.

@toji
Copy link
Member

toji commented Jun 12, 2019

Yes, sorry. To be clear: The editors support this change and are open to anyone posting a PR for it.

@bricetebbs
Copy link
Contributor

Created #699 for this.

@Manishearth Manishearth added the fixed by pending PR A PR that is in review will resolve this issue. label Jun 14, 2019
@bricetebbs
Copy link
Contributor

Created a new PR #707 for this. Sorry.

@toji
Copy link
Member

toji commented Jun 17, 2019

Closed by #707

@toji toji closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed by pending PR A PR that is in review will resolve this issue. help wanted This is a good issue for anyone to pick up and work on filing a PR for. potential breaking change Issues that may affect the core design structure.
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
5 participants
@bricetebbs @cwilso @toji @Manishearth @ddorwin