Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fields are ignored when reobfuscating to srg #28

Closed
Shevchik opened this issue Jan 13, 2014 · 7 comments
Closed

Some fields are ignored when reobfuscating to srg #28

Shevchik opened this issue Jan 13, 2014 · 7 comments

Comments

@Shevchik
Copy link

For some unknown reason BON doesn't wan't to obfuscate TileEntity xCoord, yCoord, zCoord fields.

@T145
Copy link

T145 commented Jan 13, 2014

Do you mean deobfuscate? And if so, the coordinate integer variables are available through the TileEntity class itself, representing the location of the entity. Therefore, no need for deobfuscation as they represent variables assigned in runtime.

@Shevchik
Copy link
Author

No, i mean reobfuscate to srg. The names of those fields for some reason are not reobfuscated and this results in a crash.
For example after reobfuscation xCoord should change to field_70329_l but this doesn't happen.

@T145
Copy link

T145 commented Jan 13, 2014

Have you tried reobfuscating through Forge? Deobfuscate w/ BON, decompile w/ fernflower, make changes, recompile w/ Forge, reobfuscate w/ Forge.

@Shevchik
Copy link
Author

I can't even recompile using forge, it failes to compile it's own files for some reason.
Also i'm recompiling only a part of a mod using the deobfuscated version of a mod as a library.
(Because it is almost impossible to find all libs for IC2).

@T145
Copy link

T145 commented Jan 13, 2014

Ah, IC2! Did you include all of the mods that IC2 uses as libraries? If you don't, then you'll get errors. I remember Buildcraft was at least one of them. Based off of what you described so far, I don't think this is a BON issue. It must be something wrong w/ the way you have things on your system.

@Shevchik
Copy link
Author

I managed to get forge working, but even forge reobfuscaton to srg still does not obfuscate those fields, wtf?
Currently i have to use a workaround by getting those values using reflection by that kinda sucks.

@Shevchik
Copy link
Author

I managed to fix that by myself, that was my mistake actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants