Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Panorama images are rendered as photospheres #3465

Closed
2 of 3 tasks
AndreAle94 opened this issue Jul 29, 2023 · 15 comments
Closed
2 of 3 tasks

[BUG] Panorama images are rendered as photospheres #3465

AndreAle94 opened this issue Jul 29, 2023 · 15 comments
Labels
bug Something isn't working needs triage Bug that needs triage from maintainer

Comments

@AndreAle94
Copy link
Contributor

The bug

The panorama feature introduced in the latest release is loading all images with ProjectionType=equirectangular EXIF tag as photospheres (360 images). This is working fine for photospheres but not for standard panoramas.

See the example below (taken with GCam):

  • Original image:
    PXL_20220830_122740379 PANO

  • How it's rendered:
    immagine

Not sure the library used is compatible with non-360 images, but maybe it's better to avoid rendering this type of images in 360 mode. In my opinion, a possible approach could be checking if <XMP-GPano:IsPhotosphere>True</XMP-GPano:IsPhotosphere> tag is present in metadata.

The OS that Immich Server is running on

Debian

Version of Immich Server

v1.71.0

Version of Immich Mobile App

v1.71.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

not relevant to the issue

Your .env content

not relevant to the issue

Reproduction steps

1.take a simple panorama image with Google Camera and upload it via web
2.open the image in the web application, it will be loaded as a 360 image

Additional information

No response

@AndreAle94 AndreAle94 added bug Something isn't working needs triage Bug that needs triage from maintainer labels Jul 29, 2023
@alextran1502
Copy link
Contributor

@dmitry-brazhenko Can you help take a look at this issue? Thank you

@dmitry-brazhenko
Copy link
Contributor

I will have a look

@dmitry-brazhenko
Copy link
Contributor

Well I understood the problem. Looks like that the viewer that I used is not the best one :(

Thank you so much for reporting @AndreAle94

I will explore other panorama viewers and will update it

@dmitry-brazhenko
Copy link
Contributor

dmitry-brazhenko commented Jul 29, 2023

We can assign this bug to me - I will do my best to fix it

@dominikheinz
Copy link

dominikheinz commented Jan 23, 2024

@dmitry-brazhenko Hey, I was wondering if you had this time to look into this issue yet?
What photosphere library is currently being used? This one seems pretty promising: https://photo-sphere-viewer.js.org/

(Although, I am not sure if it will also work with partial photospheres/panormas that are not fully enclosed, as shown in the linked issue above).

@alex-007
Copy link

@dmitry-brazhenko Hey, I was wondering if you had this time to look into this issue yet? What photosphere library is currently being used? This one seems pretty promising: https://photo-sphere-viewer.js.org/

(Although, I am not sure if it will also work with partial photospheres/panormas that are not fully enclosed, as shown in the linked issue above).

Actually it works with partial panoramas. Here is the demo https://photo-sphere-viewer.js.org/demos/basic/cropped-panorama.html

@dmitry-brazhenko
Copy link
Contributor

dmitry-brazhenko commented Feb 1, 2024

Hi!

Thanks for sharing.
As far as I see, Photo-Sphere-Viewer is not compatbile with svelte. I am not very good in frontend technologies. Is it possible to integrate it if there is no svelte package?

I will check it myself, but advice is appreciated

@alex-007
Copy link

alex-007 commented Feb 1, 2024

@dmitry-brazhenko I know nothing about svelte. But I googled and see an example how to use photo sphere viewer and sveltekit here. May be this would be helpful

@lynrayy
Copy link

lynrayy commented Feb 9, 2024

And some photospheres rendered wrong because they are not fully 360 captured and algorithm stitches existing parts together over black uncaptured areas

@dmitry-brazhenko
Copy link
Contributor

Seems I understood how to fix this. I am looking into it

@dmitry-brazhenko
Copy link
Contributor

2024-02-09_12-10-28

@dmitry-brazhenko
Copy link
Contributor

Here is PR with a fix: #6992

I was able to utilize Photo-Sphere-Viewer and it is more flexbile viewer

@mertalev mertalev closed this as completed Feb 9, 2024
@nicoKoehler
Copy link

@dmitry-brazhenko hey has this been rolled into the docker image yet? Last update there is from 11 days ago. Facing the same issue right now in Immich, so I am wondering when this would be available.

@dmitry-brazhenko
Copy link
Contributor

Hello @nicoKoehler!

I am just contributor to immich, not maintainer. Usually they release every 1-2 weeks, but I just merged the changed 2 days ago.
Here is a release history: https://github.com/immich-app/immich/releases

@nicoKoehler
Copy link

@dmitry-brazhenko thank you for the answer. I saw your merge but did not know what the release schedule was. I will keep an eye out for the new version then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Bug that needs triage from maintainer
Projects
None yet
Development

No branches or pull requests

8 participants