-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Panorama images are rendered as photospheres #3465
Comments
@dmitry-brazhenko Can you help take a look at this issue? Thank you |
I will have a look |
Well I understood the problem. Looks like that the viewer that I used is not the best one :( Thank you so much for reporting @AndreAle94 I will explore other panorama viewers and will update it |
We can assign this bug to me - I will do my best to fix it |
@dmitry-brazhenko Hey, I was wondering if you had this time to look into this issue yet? (Although, I am not sure if it will also work with partial photospheres/panormas that are not fully enclosed, as shown in the linked issue above). |
Actually it works with partial panoramas. Here is the demo https://photo-sphere-viewer.js.org/demos/basic/cropped-panorama.html |
Hi! Thanks for sharing. I will check it myself, but advice is appreciated |
@dmitry-brazhenko I know nothing about svelte. But I googled and see an example how to use photo sphere viewer and sveltekit here. May be this would be helpful |
This comment was marked as abuse.
This comment was marked as abuse.
Seems I understood how to fix this. I am looking into it |
Here is PR with a fix: #6992 I was able to utilize Photo-Sphere-Viewer and it is more flexbile viewer |
@dmitry-brazhenko hey has this been rolled into the docker image yet? Last update there is from 11 days ago. Facing the same issue right now in Immich, so I am wondering when this would be available. |
Hello @nicoKoehler! I am just contributor to immich, not maintainer. Usually they release every 1-2 weeks, but I just merged the changed 2 days ago. |
@dmitry-brazhenko thank you for the answer. I saw your merge but did not know what the release schedule was. I will keep an eye out for the new version then. |
The bug
The panorama feature introduced in the latest release is loading all images with
ProjectionType=equirectangular
EXIF tag as photospheres (360 images). This is working fine for photospheres but not for standard panoramas.See the example below (taken with GCam):
Original image:
How it's rendered:
Not sure the library used is compatible with non-360 images, but maybe it's better to avoid rendering this type of images in 360 mode. In my opinion, a possible approach could be checking if
<XMP-GPano:IsPhotosphere>True</XMP-GPano:IsPhotosphere>
tag is present in metadata.The OS that Immich Server is running on
Debian
Version of Immich Server
v1.71.0
Version of Immich Mobile App
v1.71.0
Platform with the issue
Your docker-compose.yml content
not relevant to the issue
Your .env content
Reproduction steps
1.take a simple panorama image with Google Camera and upload it via web 2.open the image in the web application, it will be loaded as a 360 image
Additional information
No response
The text was updated successfully, but these errors were encountered: