fix(web): prevent duplicate calls to time bucket endpoint #7563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelheusschen
approved these changes
Mar 1, 2024
alextran1502
added a commit
that referenced
this pull request
Mar 5, 2024
)" This reverts commit 8b02f18.
alextran1502
added a commit
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On page load, it's possible for the asset store's
initand the insersection handler to both try to load the same bucket. Checking for an existing cancel token prevents this and possibly other cases.An earlier iteration also removed the
loaderssection in the asset store'sinitas the intersection handler also does the same thing. However, after testing it seems to make the page load a bit snappier compared to relying only on the intersection handler.How Has This Been Tested?
Loaded timeline view with network dev tools and observed that the time bucket endpoint is only called once for a particular date.