refactor: api validators (boolean and date)

cli/src/commands/upload.command.ts

@@ -66,8 +66,8 @@ class Asset {
       assetData: new File([await fs.openAsBlob(this.path)], basename(this.path)),
       deviceAssetId: this.deviceAssetId,
       deviceId: 'CLI',
-      fileCreatedAt: this.fileCreatedAt,
-      fileModifiedAt: this.fileModifiedAt,
+      fileCreatedAt: this.fileCreatedAt.toISOString(),
+      fileModifiedAt: this.fileModifiedAt.toISOString(),
       isFavorite: String(false),
     };
     const formData = new FormData();

e2e/src/api/specs/person.e2e-spec.ts

@@ -6,10 +6,9 @@ import request from 'supertest';
 import { beforeAll, beforeEach, describe, expect, it } from 'vitest';
 
 const invalidBirthday = [
-  // TODO: enable after replacing `@Type(() => Date)`
-  // { birthDate: 'false', response: 'Invalid date' },
-  // { birthDate: '123567', response: 'Invalid date },
-  // { birthDate: 123_567, response: ['Birth date cannot be in the future'] },
+  { birthDate: 'false', response: 'birthDate must be a date string' },
+  { birthDate: '123567', response: 'birthDate must be a date string' },
+  { birthDate: 123_567, response: 'birthDate must be a date string' },
   { birthDate: new Date(9999, 0, 0).toISOString(), response: ['Birth date cannot be in the future'] },
 ];
 
@@ -152,16 +151,16 @@ describe('/person', () => {
       expect(body).toEqual(errorDto.unauthorized);
     });
 
-    it('should not accept invalid birth dates', async () => {
-      for (const { birthDate, response } of invalidBirthday) {
+    for (const { birthDate, response } of invalidBirthday) {
+      it(`should not accept an invalid birth date [${birthDate}]`, async () => {
         const { status, body } = await request(app)
           .post(`/person`)
           .set('Authorization', `Bearer ${admin.accessToken}`)
           .send({ birthDate });
         expect(status).toBe(400);
         expect(body).toEqual(errorDto.badRequest(response));
-      }
-    });
+      });
+    }
 
     it('should create a person', async () => {
       const { status, body } = await request(app)
@@ -202,16 +201,16 @@ describe('/person', () => {
       });
     }
 
-    it('should not accept invalid birth dates', async () => {
-      for (const { birthDate, response } of invalidBirthday) {
+    for (const { birthDate, response } of invalidBirthday) {
+      it(`should not accept an invalid birth date [${birthDate}]`, async () => {
         const { status, body } = await request(app)
           .put(`/person/${visiblePerson.id}`)
           .set('Authorization', `Bearer ${admin.accessToken}`)
           .send({ birthDate });
         expect(status).toBe(400);
         expect(body).toEqual(errorDto.badRequest(response));
-      }
-    });
+      });
+    }
 
     it('should update a date of birth', async () => {
       const { status, body } = await request(app)

open-api/immich-openapi-specs.json

@@ -4012,7 +4012,6 @@
             "required": false,
             "in": "query",
             "schema": {
-              "default": false,
               "type": "boolean"
             }
           }
@@ -8937,7 +8936,6 @@
       "ScanLibraryDto": {
         "properties": {
           "refreshAllFiles": {
-            "default": false,
             "type": "boolean"
           },
           "refreshModifiedFiles": {
@@ -9346,7 +9344,6 @@
             "type": "boolean"
           },
           "allowUpload": {
-            "default": false,
             "type": "boolean"
           },
           "assetIds": {

server/src/domain/album/dto/album-update.dto.ts

@@ -1,5 +1,5 @@
-import { IsBoolean, IsString } from 'class-validator';
-import { Optional, ValidateUUID } from '../../domain.util';
+import { IsString } from 'class-validator';
+import { Optional, ValidateBoolean, ValidateUUID } from '../../domain.util';
 
 export class UpdateAlbumDto {
   @Optional()
@@ -13,7 +13,6 @@ export class UpdateAlbumDto {
   @ValidateUUID({ optional: true })
   albumThumbnailAssetId?: string;
 
-  @Optional()
-  @IsBoolean()
+  @ValidateBoolean({ optional: true })
   isActivityEnabled?: boolean;
 }

server/src/domain/album/dto/album.dto.ts

@@ -1,10 +1,6 @@
-import { Transform } from 'class-transformer';
-import { IsBoolean } from 'class-validator';
-import { Optional, toBoolean } from '../../domain.util';
+import { ValidateBoolean } from '../../domain.util';
 
 export class AlbumInfoDto {
-  @Optional()
-  @IsBoolean()
-  @Transform(toBoolean)
+  @ValidateBoolean({ optional: true })
   withoutAssets?: boolean;
 }

server/src/domain/album/dto/get-albums.dto.ts

@@ -1,13 +1,7 @@
-import { ApiProperty } from '@nestjs/swagger';
-import { Transform } from 'class-transformer';
-import { IsBoolean } from 'class-validator';
-import { Optional, toBoolean, ValidateUUID } from '../../domain.util';
+import { ValidateBoolean, ValidateUUID } from '../../domain.util';
 
 export class GetAlbumsDto {
-  @Optional()
-  @IsBoolean()
-  @Transform(toBoolean)
-  @ApiProperty()
+  @ValidateBoolean({ optional: true })
   /**
    * true: only shared albums
    * false: only non-shared own albums

server/src/domain/asset/dto/asset-statistics.dto.ts

@@ -1,24 +1,16 @@
 import { AssetType } from '@app/infra/entities';
 import { ApiProperty } from '@nestjs/swagger';
-import { Transform } from 'class-transformer';
-import { IsBoolean } from 'class-validator';
-import { Optional, toBoolean } from '../../domain.util';
+import { ValidateBoolean } from '../../domain.util';
 import { AssetStats } from '../../repositories';
 
 export class AssetStatsDto {
-  @IsBoolean()
-  @Transform(toBoolean)
-  @Optional()
+  @ValidateBoolean({ optional: true })
   isArchived?: boolean;
 
-  @IsBoolean()
-  @Transform(toBoolean)
-  @Optional()
+  @ValidateBoolean({ optional: true })
   isFavorite?: boolean;
 
-  @IsBoolean()
-  @Transform(toBoolean)
-  @Optional()
+  @ValidateBoolean({ optional: true })
   isTrashed?: boolean;
 }