refactor: api validators (boolean and date) #7709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
03774d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a414e3f0.immich.pages.dev |
| Branch Preview URL: | https://refactor-api-validators.immich.pages.dev |
jrasm91
force-pushed
the
refactor/api-validators
branch
from
857faf4
to
03774d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
false, 0, etc.'false'and'true'in query params, etc.The e2e tests for the cli failed without
fileCreatedAt.toISOString()after these changes, which now require valid date strings. I'm not sure what it was doing before but it is possible it was not working correctly.