handle deconstruct_hir_ty for function pointers
#1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneksteind
force-pushed
the
feat.fp.hypo
branch
4 times, most recently
from
3b6876d
to
f2815aa
Compare
…ause we are rewriting an implicit return type of (). assert that this is not the case
aneksteind
force-pushed
the
feat.fp.hypo
branch
from
223f86b
to
d21f91d
Compare
spernsteiner
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #992. Prior to this we had no support for deconstructing the HIR ty of a function to get its arguments, which caused
handle_tyto not generate any rewrites for function pointers in struct fields. This adds support for deconstructing the signatures by first asserting that the inputs and output of an HIR function signature match the length of the MIR function signature and then packages the inputs and outputs of the HIR signature into a vector.