Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The problem of multiple chain types #14

Closed
Meng0625 opened this issue Aug 22, 2019 · 4 comments
Closed

The problem of multiple chain types #14

Meng0625 opened this issue Aug 22, 2019 · 4 comments
Assignees
Labels
tag:Methods Analysis and visualisation methods type:Question Further information is requested

Comments

@Meng0625
Copy link

Hi,

I got a question about the chain type and the clonotype definition in the tools.

It seems that each chain (no matter TCR α/β) in the same data file will be considered one type of clonotype right, instead of considering a combination of them?

So it means that different kind of chains should not be put in the same input file?

Are there any reference for this?

Many thanks,
Meng

@vadimnazarov vadimnazarov added the type:Question Further information is requested label Aug 22, 2019
@EugeneRumynskiy EugeneRumynskiy added type:Enhancement New feature or request status:Waiting for data 📁 Waiting for data sample to reproduce and removed type:Enhancement New feature or request labels Aug 28, 2019
@EugeneRumynskiy
Copy link
Contributor

Hello @MungLAW ! Yep, each chain will be considered as one type of clonotype.

You could sent a small part of the data you are working with. It will help us to deal with input formats you are using.

Next, it would be great to formulate data-problem you are trying to solve more specifically. May be we'll come up with a simple fix or solution to your case. But now It's hard to understand what functionality of Immunarch you are using.

@EugeneRumynskiy EugeneRumynskiy self-assigned this Sep 4, 2019
@EugeneRumynskiy
Copy link
Contributor

EugeneRumynskiy commented Nov 6, 2019

@MungLAW, we finally fixed this in 0.4.3 version. Just apply the repLoad function to your data, and it will split files automatically. Note the "_TRA" and "_TRB" at the end of samples, new "Chain" and "Source" columns.

To test this download this data from 10xGenomics official website (http://cf.10xgenomics.com/samples/cell-vdj/2.2.0/vdj_v1_hs_pan_t/vdj_v1_hs_pan_t_filtered_contig_annotations.csv)

Then apply repLoad:
tmp = repLoad("path/to/your/data/vdj_v1_hs_pan_t_filtered_contig_annotations.csv")

@EugeneRumynskiy EugeneRumynskiy removed the status:Waiting for data 📁 Waiting for data sample to reproduce label Nov 6, 2019
@vadimnazarov
Copy link
Contributor

Hi @MungLAW ,

did you manage to try the new version of the package? Is it working for you?

@vadimnazarov vadimnazarov added the tag:Methods Analysis and visualisation methods label Nov 30, 2019
@vadimnazarov
Copy link
Contributor

Hi @MungLAW , we are closing this issue for now, feel free to re-open it if the problem still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:Methods Analysis and visualisation methods type:Question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants