Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Libraries don't know who they are #73

Closed
xogeny opened this issue Jul 13, 2014 · 4 comments
Closed

Libraries don't know who they are #73

xogeny opened this issue Jul 13, 2014 · 4 comments

Comments

@xogeny
Copy link

xogeny commented Jul 13, 2014

The data in for each library doesn't include the libraries name. The library name only appears as a key in the enclosing map/dict. This creates an issue if you pass the library data around because the name isn't available.

@dietmarw
Copy link
Member

Can you clarify what you mean with "data in"?

@xogeny
Copy link
Author

xogeny commented Jul 13, 2014

What I mean is the index contains data like this:

  "FaultTriggering": {
      "homepage": "https://github.com/DLR-SR/FaultTriggering", 
      "description": "Library for fault modelling in Modelica", 
      "versions": {
          "0.6.2": {
            ...
          }
      }
   }

If I then grab the library data like this:

libinfo = index["FaultTriggering"];

The object libinfo no longer knows the name of the library. So if I pass libinfo to a function, that function has no idea what library this is. But if, instead, we had:

  "FaultTriggering": {
      "name": "FaultTrigger",
      "homepage": "https://github.com/DLR-SR/FaultTriggering", 
      "description": "Library for fault modelling in Modelica", 
      "versions": {
          "0.6.2": {
            ...
          }
      }
   }

Then we wouldn't have that problem.

Is that clear?

@dietmarw
Copy link
Member

Ah yes that's clear now.

@dietmarw dietmarw added this to the v0.7.0 indexing milestone Dec 11, 2014
@xogeny
Copy link
Author

xogeny commented Apr 19, 2015

No longer a problem. Libraries know who they are. They even have a canonical URI to disambiguate forks, etc.

@xogeny xogeny closed this as completed Apr 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants