-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues/611 - Email Enhancement #1673
Conversation
@DevinWalker Currently, you will not able to see recipients setting in form meta box. The new form API support repeater field in form meta box. I will fix that after merging this to |
@mathetos can you get your eyes on this for me and give it a thorough test with core, per-form emails, recurring and other add-ons that modify or customize emails? |
@mathetos Check updates GENERAL COMMENTS/TWEAKS
Bugs
|
@ravinderk Looks good. Let me clarify #2 though. The email sends correctly, but the link inside the email doesn't lead to any specific page. If they test that email and click on that link I think it just goes to a 404. I'm not sure whether we can have it go somewhere more obvious or actionable, but it makes testing that email less effective. |
@mathetos In test email whatever content you see ( for example new donation email ), it is real content but email tag values are only dummy values which give you feel of the actual email. Email tag dummy values can be set by the developer. For example, receipt email tag will have a correct link only if a donor donates something. @mathetos I agree with you that this will make testing email less effective for testing. But before making donation form live they can process donation from their end first by this way they will get an actual email. @DevinWalker What is your views on that. |
Description
This PR will fix #1346
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: