Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Billing Fields as an option in PayPal Standard #1573

Closed
3 tasks done
mathetos opened this issue Mar 10, 2017 · 0 comments
Closed
3 tasks done

Add Billing Fields as an option in PayPal Standard #1573

mathetos opened this issue Mar 10, 2017 · 0 comments
Assignees
@DevinWalker
Milestone
1.8.5

Comments

@mathetos
Copy link
Member

mathetos commented Mar 10, 2017 •
edited by DevinWalker
Loading

Issue Overview

We should give Site Admins the option to add Billing Fields to their donation forms for PayPal Standard and ensure that those fields get passed directly to PayPal.com.

Possible Solution

We already have this filter, just need to wrap it as a setting:
add_action( 'give_paypal_cc_form', 'give_default_cc_address_fields' );

Todos

  • Create the setting as "Add Billing Fields : Enabled | Disabled"
  • Ensure that setting is reflected on the forms globally
  • Ensure fields are passed correctly to paypal.com
@DevinWalker DevinWalker self-assigned this Mar 16, 2017
@DevinWalker DevinWalker added this to the 1.8.5 milestone Mar 16, 2017
DevinWalker pushed a commit that referenced this issue Mar 16, 2017
New option to toggle billing details and corresponding logic #1573
e990f09
@DevinWalker DevinWalker mentioned this issue Mar 16, 2017
Merged
3 tasks
DevinWalker pushed a commit that referenced this issue Mar 16, 2017
Merge pull request #1583 from WordImpress/issue/1573
caa52b6 
New option to toggle billing details and corresponding logic #1573
DevinWalker pushed a commit that referenced this issue Mar 16, 2017
Merge branch 'release/1.8.5'
624ddd2 
* release/1.8.5:
  New option to toggle billing details and corresponding logic #1573
DevinWalker pushed a commit that referenced this issue Mar 29, 2017
Merge branch 'release/1.8.6' into issue/1571
6866344 
* release/1.8.6:
  Improved payment status language
  Reordered to fix travis error
  Attempting to fix broken PHPunit tests
  Fix: typo in currency section setting
  Fix: generate level class and id with price_id instead of
  fix #1592
  Update README.md
  Update Documentation.
  New POT file for 1.8.5
  Change log updated with completed issues
  New option to toggle billing details and corresponding logic #1573
  Version bumped, change log added - more to add
  Code formatting
  Added exception for offline donations meta_key upgrades #1579
  Ensure upgrade can run on any WP-admin page, don’t rely on give_vars which was throwing a console error and the confirm window would never show #1580
  Updated give_logged_in_only to return enabled if metakey `_give_logged_in_only` returns empty #1578
  Fix typo
  Add comment
  Render continue button title setting field conditionaly in shortcode generator popup
  Show/Hide on continue button title in widget form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.8.5
Development

No branches or pull requests
2 participants
@mathetos @DevinWalker