Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilevel Form issues with 10+ options. #1592

Closed
1 task
Benunc opened this issue Mar 28, 2017 · 0 comments
Closed
1 task

Multilevel Form issues with 10+ options. #1592

Benunc opened this issue Mar 28, 2017 · 0 comments
Assignees
@ravinderk
Milestone
1.8.6

Comments

@Benunc
Copy link
Member

Benunc commented Mar 28, 2017

Issue Overview

Multilevel forms with lots of options are selecting the wrong option on click. Will do my best to clarify.

Expected Behavior

Multilevel forms with lots of options should work

Current Behavior

Once there are a certain number of level options, selecting them (no matter if it is dropdown, radio, or button) selects the last one.

Steps to Reproduce (for bugs)

  1. New multilevel form with 15 options. Name them whatever you'd like, set the levels however you'd like.
  2. Save/publish the form and visit it. options 12-15 (roughly, I haven't nailed down exactly how many will exhibit the bad behavior) will all click to 15.

Notes

Once the form is initially published, going back in and deleting the TOP options from the list does not seem to have an effect on the bottom ones.

Reordering the fields causes even more weirdness.

Also of note is that the amounts sometimes register correctly (and differently than the "selected" level) and sometimes they don't.

Here's a live example: https://www.habitatsoco.org/annual-charity-golf-tournament-reg-copy-2-copy-copy

Todos

  • Tests
ravinderk added a commit to ravinderk/Give that referenced this issue Mar 29, 2017
@ravinderk
fix impress-org#1592
1c20562
@ravinderk ravinderk mentioned this issue Mar 29, 2017
Merged
DevinWalker pushed a commit that referenced this issue Mar 29, 2017
Merge pull request #1593 from ravinderk/issues/1592
51d04d5 
fix #1592
@DevinWalker DevinWalker added this to the 1.8.6 milestone Mar 29, 2017
DevinWalker pushed a commit that referenced this issue Mar 29, 2017
Merge branch 'release/1.8.6' into issue/1571
6866344 
* release/1.8.6:
  Improved payment status language
  Reordered to fix travis error
  Attempting to fix broken PHPunit tests
  Fix: typo in currency section setting
  Fix: generate level class and id with price_id instead of
  fix #1592
  Update README.md
  Update Documentation.
  New POT file for 1.8.5
  Change log updated with completed issues
  New option to toggle billing details and corresponding logic #1573
  Version bumped, change log added - more to add
  Code formatting
  Added exception for offline donations meta_key upgrades #1579
  Ensure upgrade can run on any WP-admin page, don’t rely on give_vars which was throwing a console error and the confirm window would never show #1580
  Updated give_logged_in_only to return enabled if metakey `_give_logged_in_only` returns empty #1578
  Fix typo
  Add comment
  Render continue button title setting field conditionaly in shortcode generator popup
  Show/Hide on continue button title in widget form
DevinWalker pushed a commit that referenced this issue Mar 30, 2017
Merge branch 'release/1.8.6' into mathetos-release/1.9
730aa83 
* release/1.8.6:
  Thou shalt not support PHP 5.2
  Improved payment status language
  Reordered to fix travis error
  Attempting to fix broken PHPunit tests
  Fix: typo in currency section setting
  Fix: generate level class and id with price_id instead of
  fix #1592
  Update README.md
  Update Documentation.
  Text update
  Removed duplicate
  returns array of objects
  Return “all” rather than empty to prevent conflicts with level ID 0
  Remove space
  Prettier nonce failure notice #1571
  Code reformatting
  Removed unused variables
  Removed unused code #1571

# Conflicts:
#	assets/js/admin/admin-scripts.min.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
1.8.6
Development

No branches or pull requests
3 participants
@DevinWalker @ravinderk @Benunc