Upgrade routine cannot run on plugins listing page due to JS error #1580
Assignees
Milestone
Comments
DevinWalker
pushed a commit
that referenced
this issue
Mar 15, 2017
…which was throwing a console error and the confirm window would never show #1580
DevinWalker
pushed a commit
that referenced
this issue
Mar 29, 2017
* release/1.8.6: Improved payment status language Reordered to fix travis error Attempting to fix broken PHPunit tests Fix: typo in currency section setting Fix: generate level class and id with price_id instead of fix #1592 Update README.md Update Documentation. New POT file for 1.8.5 Change log updated with completed issues New option to toggle billing details and corresponding logic #1573 Version bumped, change log added - more to add Code formatting Added exception for offline donations meta_key upgrades #1579 Ensure upgrade can run on any WP-admin page, don’t rely on give_vars which was throwing a console error and the confirm window would never show #1580 Updated give_logged_in_only to return enabled if metakey `_give_logged_in_only` returns empty #1578 Fix typo Add comment Render continue button title setting field conditionaly in shortcode generator popup Show/Hide on continue button title in widget form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Overview
When testing #1578 and #1579 I noticed that when on the plugins listing page the JS confirm window was not loading due to a JS error:
This is preventing the user from ever running the upgrade routine.
Expected Behavior
The upgrade routine can be ran anywhere within WP-admin
Current Behavior
The upgrade routine cannot run on the plugins page. I will also check other pages.
Possible Solution
Ensure
give_varsis available throughout wp-adminSteps to Reproduce (for bugs)
Related PRs
List related PRs against other branches:
Todos
The text was updated successfully, but these errors were encountered: