Add proper text preferably donation amount to Paypal item title instead of custom amount text

[marutim]

Issue Overview

It happens for both single or multi level forms. When a donation is processed with fee recovery checked and payment is done via paypal. The paypal item title is suffixed with the "custom amount text". This also happens even when the custom amount is disabled for the form.

For example if you set donation amount is $10 and fee recovery is $0.20 and Custom amount text is "More the better" the paypal item title will be Donation form name - "More
the better". When custom amount is disabled or custom amount text is not set, it uses the default custom amount text which is "Custom Amount"

Expected Behavior

Paypal item title should be suffixed with proper text, which can be the correct level for multi level form or no suffix or the donated total amount (including the recovery fee)

Current Behavior

Paypal item title is suffixed with the custom amount text

Possible Solution

In the function give_build_paypal_item_title(), the logic is set to consider the donation amount to custom when it doesn't match to any level amount. We need to make an exception for fee recovery addition.

Steps to Reproduce (for bugs)

• Make a donation using the single or multi level form, check the fee recovery and process the donation via Paypal.
• In the Paypal page, check for the item title.
• Please review the screenshots for better understanding

Screenshots

[mathetos]

Excellently written issue @marutim Thanks!

[marutim]

Thanks @mathetos :)

[ravinderk]

@mehul0810 Improve as deprecated function described in comment https://github.com/WordImpress/Give/pull/2075/files#diff-becfcb2300911b460438043c3c352ba3R640

[DevinWalker]

Good call with deprecating the function. Don't want to cause errors for folks who may be using it.