Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve donor detail page heading #2286

Closed
2 tasks
ravinderk opened this issue Nov 3, 2017 · 4 comments
Closed
2 tasks

Improve donor detail page heading #2286

ravinderk opened this issue Nov 3, 2017 · 4 comments
Assignees
@raftaar1191
Milestone
2.0.3

Comments

@ravinderk
Copy link
Collaborator

Issue Overview

We can show donor name on donor detail page instead of donor ID.

Donor detail page:
screen shot 2017-11-03 at 1 50 37 pm

WordPress user edit page
screen shot 2017-11-03 at 1 50 27 pm

Todos

  • Development
  • Review Heading
@ravinderk
Copy link
Collaborator Author

@DevinWalker @mathetos

Slack conversion summary:

‘Edit Donor’ would follow suit with the rest of WP admin. Typically the title of the page reflects the action being taken. It doesn’t include specifics.

I liked your suggestion @Ravinder. I think that ID is of no importance for a user. But, change it to Edit Donor: Mehul Gohil will make a difference to a user. The user will immediately know that he is accessing the donor profile of so and so person and we all know that bigger heading will attract eyesight more easily.

So New heading will look like Edit Donor: {firstname} {lastname}.

@ravinderk ravinderk added this to the 1.8.17 milestone Nov 3, 2017
@DevinWalker
Copy link
Member

The ID is of some importance. I'd like to see it updated as:

Edit Donor #123: {firstname} {lastname}

@DevinWalker DevinWalker modified the milestones: 1.8.17, 2.0.1 Nov 6, 2017
@DevinWalker
Copy link
Member

I'm bumping off 1.8.17 as we need to focus on 2.0

@raftaar1191
Copy link
Contributor

Okay @DevinWalker

@ravinderk ravinderk modified the milestones: 2.0.1, 2.0.2 Jan 22, 2018
@DevinWalker DevinWalker modified the milestones: 2.0.2, 2.0.3 Jan 27, 2018
@ravinderk ravinderk modified the milestones: 2.0.3, 2.0.2 Jan 29, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018
@raftaar1191
Update Donor Single page title impress-org#2286
5b26ead
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018
@raftaar1191
Remove esc html impress-org#2286
06ac165
@raftaar1191 raftaar1191 mentioned this issue Jan 29, 2018
Merged
3 tasks
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018
@raftaar1191
Add donor first name and donor last name impress-org#2286
f7da9b9
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018
@raftaar1191
Document Updated impress-org#2286
cb24e5b
DevinWalker added a commit that referenced this issue Jan 29, 2018
@DevinWalker
Merge branch 'release/2.0.2' into issue/339
53d9146 
* release/2.0.2: (22 commits)
  Fix Status issues when importing donation #2725
  Add donor first name and donor last name #2286
  Remove esc html #2286
  Update Donor Single page title #2286
  Open link in a new window - Resolves #2727
  Unrelated code cleanup #2728
  Use WP_Query and not get_posts so meta_query works with new forms meta table - Resolves #2728
  FIx changelog
  Add style to display tr tag in online line #2706
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  ...

# Conflicts:
#	assets/css/give-admin-rtl.css
#	assets/css/give-admin-rtl.min.css
#	assets/css/give-admin.css
#	assets/css/give-admin.min.css
#	assets/sourcemaps/give-admin.css.map
DevinWalker added a commit that referenced this issue Jan 29, 2018
@DevinWalker
Merge branch 'issue/339' into feature/gutenberg-donation-form-block
7b6f136 
* issue/339: (22 commits)
  Fix Status issues when importing donation #2725
  Add donor first name and donor last name #2286
  Remove esc html #2286
  Update Donor Single page title #2286
  Open link in a new window - Resolves #2727
  Unrelated code cleanup #2728
  Use WP_Query and not get_posts so meta_query works with new forms meta table - Resolves #2728
  FIx changelog
  Add style to display tr tag in online line #2706
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raftaar1191 raftaar1191

Labels
None yet
Projects
None yet
Milestone
2.0.3
Development

No branches or pull requests
3 participants
@DevinWalker @ravinderk @raftaar1191