Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import doesn't import Donations or Donors in version 2.0.1 #2725

Closed
mathetos opened this issue Jan 26, 2018 · 5 comments
Closed

Import doesn't import Donations or Donors in version 2.0.1 #2725

mathetos opened this issue Jan 26, 2018 · 5 comments
Assignees
@raftaar1191

Comments

@mathetos
Copy link
Member

Issue Overview

Import doesn't import Donations or Donors in version 2.0.1

Expected Behavior

Importer should import all donations and donors

Current Behavior

It creates the form correctly, but not any donations or donors.

Steps to Reproduce (for bugs)

  1. Install 2.0.1 from wordpress.org

  2. Import using this CSV file: https://drive.google.com/file/d/10pw7q_0l02Rg6MvErXsAnYJ_OFOaYAIf/view?usp=sharing

  3. Everything maps automatically. I removed the "Form ID" from being mapped

  4. Run the import and you'll get a success message:
    image

  5. But then navigate to Donations and/or Donors and nothing will be there

  6. Navigate to All Forms and one form will have been created successfully
@mathetos mathetos added the bug label Jan 26, 2018
@mathetos
Copy link
Member Author

I actually tested this problem with version 1.8.19 and 2.0.1. I'm assuming 2.0.0 is also a problem.

@DevinWalker DevinWalker added this to the 2.0.2 milestone Jan 27, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Jan 29, 2018
@raftaar1191
Fix Status issues when importing donation impress-org#2725
0f088ff
@raftaar1191
Copy link
Contributor

I am able to regenerate this issues with 1.8.19 as well as with 2.0.2. The problem was with Donation status parameter it only used to work when proper status key is pass to it

image

image

Fixing this issue and sending the PR. For now, admin can pass status key as well as status name

@raftaar1191 raftaar1191 mentioned this issue Jan 29, 2018
Merged
2 tasks
ravinderk added a commit that referenced this issue Jan 29, 2018
@ravinderk
Merge pull request #2733 from raftaar1191/issues-2725
2068bd0 
Fix Status issues when importing donation #2725
@ravinderk
Copy link
Collaborator

ravinderk commented Jan 29, 2018 •
edited

@mathetos This issue auto close. Reopen if you are able to reproduce this issue.

DevinWalker added a commit that referenced this issue Jan 29, 2018
@DevinWalker
Merge branch 'release/2.0.2' into issue/339
53d9146 
* release/2.0.2: (22 commits)
  Fix Status issues when importing donation #2725
  Add donor first name and donor last name #2286
  Remove esc html #2286
  Update Donor Single page title #2286
  Open link in a new window - Resolves #2727
  Unrelated code cleanup #2728
  Use WP_Query and not get_posts so meta_query works with new forms meta table - Resolves #2728
  FIx changelog
  Add style to display tr tag in online line #2706
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  ...

# Conflicts:
#	assets/css/give-admin-rtl.css
#	assets/css/give-admin-rtl.min.css
#	assets/css/give-admin.css
#	assets/css/give-admin.min.css
#	assets/sourcemaps/give-admin.css.map
DevinWalker added a commit that referenced this issue Jan 29, 2018
@DevinWalker
Merge branch 'issue/339' into feature/gutenberg-donation-form-block
7b6f136 
* issue/339: (22 commits)
  Fix Status issues when importing donation #2725
  Add donor first name and donor last name #2286
  Remove esc html #2286
  Update Donor Single page title #2286
  Open link in a new window - Resolves #2727
  Unrelated code cleanup #2728
  Use WP_Query and not get_posts so meta_query works with new forms meta table - Resolves #2728
  FIx changelog
  Add style to display tr tag in online line #2706
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  ...
@mathetos
Copy link
Member Author

This doesn't seem to have been resolved.

Steps to Reproduce

  • Be on any Give version from 1.8.19 - 2.0.6
  • Try to import this CSV file : https://drive.google.com/open?id=11mOVzYqonrb_965EgSF_9jcTwn3odeAl
  • It should import TWO unique donors, with TWO unique donations, and create TWO different Forms and associate those donations with those forms.
  • Instead it only imports the donors with NO donations and NO forms. This success message is accurate, notice it does not mention donations or forms:
    image

I've tried this in many different environments, and mapping the fields in different ways. Same result every time.

@mathetos mathetos reopened this Mar 23, 2018
@mathetos mathetos removed this from the 2.0.2 milestone Mar 23, 2018
@mathetos
Copy link
Member Author

Just tested on the 2.0.7 branch and all is well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raftaar1191 raftaar1191

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mathetos @DevinWalker @ravinderk @raftaar1191