Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having ajax issue admin notice link open in new tab/window #2727

Closed
tw2113 opened this issue Jan 27, 2018 · 1 comment
Closed

Consider having ajax issue admin notice link open in new tab/window #2727

tw2113 opened this issue Jan 27, 2018 · 1 comment
Assignees

Comments

@tw2113
Copy link
Contributor

tw2113 commented Jan 27, 2018

screenshot from 2018-01-27 14-16-08

Potentially contentious with accessibility and whatnot, but may not be a bad idea to leave users in their admin dashboard with the learn more link from this admin notice.

@ravinderk ravinderk added this to the 2.0.2 milestone Jan 28, 2018
@DevinWalker
Copy link
Member

Yeah I think that's a good idea.

@DevinWalker DevinWalker assigned DevinWalker and unassigned mehul0810 Jan 28, 2018
DevinWalker added a commit that referenced this issue Jan 29, 2018
* release/2.0.2: (22 commits)
  Fix Status issues when importing donation #2725
  Add donor first name and donor last name #2286
  Remove esc html #2286
  Update Donor Single page title #2286
  Open link in a new window - Resolves #2727
  Unrelated code cleanup #2728
  Use WP_Query and not get_posts so meta_query works with new forms meta table - Resolves #2728
  FIx changelog
  Add style to display tr tag in online line #2706
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  ...

# Conflicts:
#	assets/css/give-admin-rtl.css
#	assets/css/give-admin-rtl.min.css
#	assets/css/give-admin.css
#	assets/css/give-admin.min.css
#	assets/sourcemaps/give-admin.css.map
DevinWalker added a commit that referenced this issue Jan 29, 2018
* issue/339: (22 commits)
  Fix Status issues when importing donation #2725
  Add donor first name and donor last name #2286
  Remove esc html #2286
  Update Donor Single page title #2286
  Open link in a new window - Resolves #2727
  Unrelated code cleanup #2728
  Use WP_Query and not get_posts so meta_query works with new forms meta table - Resolves #2728
  FIx changelog
  Add style to display tr tag in online line #2706
  rename "customer_id" variables to a better fit of "donor_id"
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect proper default value
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect multiple possible variable types
  update phpdoc to reflect actual default value
  remove unneeded period after a variable.
  update object type variable
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants