Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Give Settings section #668

Closed
DevinWalker opened this issue Jun 29, 2016 · 2 comments
Closed

Refactor the Give Settings section #668

DevinWalker opened this issue Jun 29, 2016 · 2 comments
Assignees
Milestone

Comments

@DevinWalker
Copy link
Member

Now that we have tabbed the main settings page, let's tab out the subsections too so it's less cluttered on each page.

@DevinWalker DevinWalker added this to the 1.6 milestone Jun 29, 2016
@DevinWalker DevinWalker self-assigned this Jun 29, 2016
@DevinWalker
Copy link
Member Author

After reviewing this thoroughly I think we should reassess how our settings section is currently developed. CMB2 is pretty lackluster in it's ability to create settings pages. The new ability to toggle between tabs without page refresh is convenient but can potentially cause issues with other Add-ons. I propose that we develop a similar approach as Woo with an abtract class and
https://github.com/woothemes/woocommerce/blob/master/includes/admin/class-wc-admin-settings.php and various extended classes for the settings tabs: https://github.com/woothemes/woocommerce/tree/master/includes/admin/settings

Thoughts?

@DevinWalker DevinWalker changed the title Settings Subsections Need Subtabs Refactor the Give Settings section Jul 6, 2016
@DevinWalker
Copy link
Member Author

After some heavy forking I decided this needs to be bumped from the currently scheduled milestone. It's a significant undertaking that will require lots of dev and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants