Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create settings update script for settings changes #976

Closed
mathetos opened this issue Aug 29, 2016 · 4 comments
Closed

Create settings update script for settings changes #976

mathetos opened this issue Aug 29, 2016 · 4 comments
Assignees
@DevinWalker @ravinderk
Milestone
1.8

Comments

@mathetos
Copy link
Member

Resolving #962 creating a new issue. All the instances where "check to disable" where used will break with the new radio buttons because they now use "Enable/Disable" and the value is "on" or "no value".

In discussing this with @DevinWalker he recommended that rather than inverse the values for these settings (which would create tons of developer confusion) we should create an update script in version 1.7 to resolve it.

Here are the affected settings which will need updating via the new script:

Payment Gateways Tab

  • "PayPal IPN Verification"

Display Options Tab

  • "Disable CSS"
  • "Disable Welcome Screen"
  • "Disable Form Single Views"
  • "Disable Form Archives"
  • "Disable Form Excerpts"
  • "Disable Form Featured Image"
  • "Disable Single Form Sidebar"

Emails Tab

  • "Disable Admin Notifications"

Advanced Tab

  • "Disable the_content filter"
@mathetos mathetos added this to the 1.7 milestone Aug 29, 2016
@DevinWalker DevinWalker self-assigned this Aug 31, 2016
@DevinWalker
Copy link
Member

Ravinder took care of this for #668 - see: d44feb9

@DevinWalker DevinWalker modified the milestone: 1.7 Sep 30, 2016
@DevinWalker DevinWalker assigned ravinderk and unassigned DevinWalker Sep 30, 2016
@DevinWalker
Copy link
Member

Sorry, @ravinderk made it clear to me that you're talking about the Settings screen, not the Single Donation Form creation page. Reopening...

@DevinWalker DevinWalker reopened this Sep 30, 2016
@DevinWalker DevinWalker modified the milestones: 1.8, 1.7 Sep 30, 2016
@ravinderk ravinderk mentioned this issue Sep 30, 2016
Merged
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
Test mode is now radio #976
e3f71fb
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
disable_css now a radio
cd19814 
enable_floatlabels now a radio
disable_welcome now a radio

also updated various descriptions and incorrectly disabled fields #976
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
email_access now a radio
60ed7eb 
minor code formatting #976
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
Include the previously changed fields in the upgrade func #976
5734fe8
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
Text "Global Options" is now "Global Options" (no s at the end) #976
f2b353d
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
"Terms and Conditions" needed a global enable disable option #976
7fa7cd9
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
added uninstall_on_delete and scripts_footer to upgrade script #976
61fef5e
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
Style tweak so radio inline field descriptions don't have a noticeabl…
6221697 
…y larger spacing than other field types #976
@DevinWalker DevinWalker reopened this Sep 30, 2016
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
Fixing toggling of enable_categories and enable_tags #976
bc7b960
DevinWalker pushed a commit that referenced this issue Sep 30, 2016
Ensure disable_css returns enabled by default #976
b7ee653
@ravinderk
Copy link
Collaborator

@DevinWalker Here are testing instruction for core settings with new setting api:

How to test

To test upgrade setting process we need two sites with give plugin already installed, because settings only update once when switch to release/1.8 and we need fresh give_settings before switch to git brach release/1.8

Note: I am assuming we have two sites give-1 (main testing site) and give-2 (take fresh give_settings from this site).

Steps

  1. Switch to git branch other then release/1.8 which have version < 1.8.
    a. if you not already tested settings then update settings as you want.

    b. if you already tested settings once then get fresh give_settings option value from give-2
    and update give_settings directly into give-1 db. You can also update settings on give-2 before migrate as you want to test.

  2. After updating setting switch git branch to release/1.8 and check settings in new setting api.

  3. If you do not find any bug/issues , then goto step 1.

@DevinWalker DevinWalker self-assigned this Oct 27, 2016
@DevinWalker
Copy link
Member

Tested and it's working nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@mathetos @DevinWalker @ravinderk