feat(admin-tool): merge CSV toolbox into Give core #2875 #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raftaar1191
changed the title
|
@raftaar1191 Arrange checkboxes in columns form like below image:
|
ravinderk
requested changes
Apr 2, 2018
ravinderk
requested changes
Apr 2, 2018
| var give_form_id; | ||
|
|
||
| // Check for form ID. | ||
| if ( ! ( |
There was a problem hiding this comment.
@raftaar1191 improve code formatting here.
| output_give_donations_fields( response ); | ||
|
|
||
| } else { | ||
| alert( 'An AJAX error occurred.' ); |
There was a problem hiding this comment.
@raftaar1191 this must be translatable
|
@ravinderk updated the PR as you have mentioned in requested changes
|
raftaar1191
changed the title
kevinwhoffman
changed the title
DevinWalker
reviewed
Apr 3, 2018
| /** | ||
| * Ajax call to get donation fields. | ||
| */ | ||
| $( '.give-export_donations #give-export_donations-form #give_form_for_csv_export' ).chosen().change( function () { |
There was a problem hiding this comment.
@raftaar1191 please remove this from create a new JS file called admin-exports.js
There was a problem hiding this comment.
Okay @DevinWalker doing that
Change Requests1. Vertically align to the top top align rows
2. Fix indent
3. Make this export the first option
4. Update your checklist and complete any missing items still unchecked/fixed
|
|
@DevinWalker Update PR with all the suggestion that you have made |
|
@raftaar1191 can you fix the conflict in this PR? |
# Conflicts: # includes/admin/tools/views/html-admin-page-exports.php
|
@DevinWalker merge conflict resolved. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to fix #2875
How Has This Been Tested?
Manually Tested after removing the Export Donation History Code and then add the CSV ToolBox Code to Give Core 2.1 and exporting the donation from the CSV
Task List
Screenshots (jpeg or gifs if applicable):
View the Export Page
With out selecting the Donation Form:
When selecting the Donation Form:
Types of changes