fix(shortcode): select donation form alert must be open using modal api #3244 #3282 #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(form): do not unformat the min/max amount using JS functions.
fix(admin-form): prevent js notice when edit price type setting field #3161
fix(admin-setting): prevent setting menu to appear on top of modal #3164
* release/2.1.1: fix(admin-shortcode): clarify Donation Form Grid shortcode generator fix(db-upgrade): do not show upgrade notice on WP update page fix(donation): update default donation amount fix(donation): update form max value fix(donation): improve if condition
* release/2.1.2: doc(release): Add change log for 2.1.1 and run npm prod for new POT file
* release/2.1.3: style(code): improve code formatting fix(admin-settings): Disables radio button if payment gateway is disabled fix(donation): improved the logic of checking min/max amount. feat(admin-email): Add email header for 3 email notification types Added email header option for new donation, receipt and offline donation instructions. feat(admin-email): Add setting field for email header
* release/2.1.4: doc(release): update new branch version doc(release): add change log for 2.1.3 and run npm prod feat(admin-tool): Change action and filter name feat(admin-tool): Added a new action and filter doc(release): bump version number doc(release): run npm production before release and add change log
* release/2.1.4: doc(release): gen new POT file for release fix: improve error description fix(donation): update code to support latin characters for donations doc(release): new POT generated for master branch since we merged commits pre-merge to master
fix(compat): prevent missing donation data with Restrict Content Pro #2710
# Conflicts: # includes/admin/donors/donor-actions.php # includes/admin/payments/view-payment-details.php # includes/misc-functions.php
fix(admin-tool): export and Import of Donations must be in sync without errors #2135
|
@Sidsector9 recreate this pr as we discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3282
Description
This PR replaces the native alert dialog with GiveModalWarning.
How Has This Been Tested?
By adding a form in a shortcode without choosing a form.
Screenshots (jpeg or gifs if applicable):
Checklist: