Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_apply_drag_force() seems unused, and unstable reward curve during trainning #2

Closed
utomm opened this issue Oct 13, 2023 · 1 comment

Comments

@utomm
Copy link

utomm commented Oct 13, 2023

Question about _apply_drag_force() method and reward stability:

Hi, thanks for sharing the source code of such an interesting and impressive work!

I've been exploring the code, and I noticed something that raised a question. In the LeggedRobot class, there is an _apply_drag_force() method. However, it seems this method is actually unused during simulation, which is different from what's described in the original paper. Is the open-sourced code is a modified version or it is just because the force is forgotten to be applied in the code?

Additionally, when attempting to reproduce the results using the provided training script, I encountered some issues with the stability of the reward curve. Is this expected behavior, or is there something I might be missing?

Thank you for your attention to this issue.

image

@gmargo11
Copy link
Collaborator

Hi @HuSha3k ,

There was indeed an issue with the apply_drag_force function. I have fixed it in the latest commit 8e743ac to match the implementation from the paper. You should find that it significantly stabilizes training. Thanks for your patience!

-Gabe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants