-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to allow specific CORS origin for api #357
Comments
I see that there is already an open PR for a "fresh start", so you should take this issue into consideration if you intend to use the same logic to choose between running api/web mode. |
Could you possibly take this into consideration as well? When using authentication in front of the cobalt frontend, I am unable to retrieve the manifest file cause of the CORS issue. "If the manifest requires credentials to fetch, the crossorigin attribute must be set to use-credentials, even if the manifest file is in the same origin as the current page." Adding |
hey! i've updated the env variable to be make sure you're on 7.10.3 and try again, lmk if it works this time. |
Works. |
bug description
I believe setting
cors=0
in the environment variables does not do anything.Here we can see that when
cors === '0'
, corsConfig is set to{ origin: process.env.webURL, optionsSuccessStatus: 200 }
.Unfortunately,
process.env.webURL
will always beundefined
, simply because apiMode istrue
only whenprocess.env.webURL
isundefined
(see here).The text was updated successfully, but these errors were encountered: