Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Bun #489

Closed
lonelil opened this issue May 9, 2024 · 5 comments
Closed

Migrate to Bun #489

lonelil opened this issue May 9, 2024 · 5 comments
Labels
feature request New feature or request

Comments

@lonelil
Copy link

lonelil commented May 9, 2024

describe the feature you'd like to see
Switch from nodejs to bun

additional context
Bun is faster and more lightweight than nodejs

@lonelil lonelil added the feature request New feature or request label May 9, 2024
@lonelil
Copy link
Author

lonelil commented May 9, 2024

i can pr this if wanted

@dumbmoron
Copy link
Member

Bun is faster and more lightweight than nodejs

could you make a benchmark for this, in the context of cobalt?

@lonelil
Copy link
Author

lonelil commented May 12, 2024

did some testing and bun was somehow slower, the setup cli and the api was slower to start and bun would crash when requesting the stream endpoint 💀

@wukko
Copy link
Member

wukko commented May 12, 2024

bun was somehow slower

so, is it good to close the issue as request is invalid?

@catdevnull
Copy link

if it helps with anything, i've tried bun for many use cases (including one or two scrapers) and every time i've had weird crashes or memory leaks. unless there's a specific reason to use bun, i don't see why

@lonelil lonelil closed this as completed May 14, 2024
@dumbmoron dumbmoron closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants