Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from tslint to typescript-eslint #88

Closed
imRohan opened this issue Sep 7, 2021 · 2 comments · Fixed by #95
Closed

Switch from tslint to typescript-eslint #88

imRohan opened this issue Sep 7, 2021 · 2 comments · Fixed by #95
Assignees
@kaffarell
Labels
dependencies Pull requests that update a dependency file

Comments

@imRohan
Copy link
Owner

imRohan commented Sep 7, 2021

There's still one linter failure locally, but it's because tslint crashes. This bug was reported (palantir/tslint#4949), but hasn't been fixed because tslint is deprecated. You might want to switch to typescript-eslint or another linting tool.

Originally posted by @AnnikaCodes in #84 (comment)
@imRohan imRohan added enhancement New feature or request dependencies Pull requests that update a dependency file and removed enhancement New feature or request labels Sep 7, 2021
@kaffarell kaffarell mentioned this issue Sep 10, 2021
Merged
@imRohan
Copy link
Owner Author

imRohan commented Sep 10, 2021

@kaffarell I'll assign this one to you if thats ok? 😄

@kaffarell
Copy link
Contributor

@imRohan ok

imRohan pushed a commit that referenced this issue Sep 16, 2021
@kaffarell
Migrated from tslint to eslint (#95)
b16c5b1 
* Migrated from tslint to eslint
* Fixed a few eslint errors
* Fixed most of the linter errors and settings
* Fixed the easily fixable linter errors like trailing whitespace. Next up is typing.
* Finalized eslint installation, fixed package.json script & also removed tslint
* Fixed eslint brace-style rule allowSingleLine for braces
* Removed comments from config file, fixed typo

Fixes: #88, #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaffarell kaffarell

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrating from tslint to eslint
2 participants
@imRohan @kaffarell