Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Diagonal lines/border? #213

Closed
Quix0r opened this issue Oct 23, 2017 · 8 comments
Closed

[Enhancement] Diagonal lines/border? #213

Quix0r opened this issue Oct 23, 2017 · 8 comments

Comments

@Quix0r
Copy link

Quix0r commented Oct 23, 2017

Is it possible to render diagonal lines and a border? I mean something like this:

http://dhiglobal.com/wp-content/uploads/2016/07/placeholder.jpg

Here, the border is missing, maybe a new config border = true/false (default: false) and diagonals = true/false (default: false)?

@imsky
Copy link
Owner

imsky commented Oct 23, 2017

this already exists, use outline=1, e.g. <img data-src="holder.js/300x200?outline=1">

example: https://jsfiddle.net/m28ntzou/

screen shot 2017-10-23 at 11 09 42 am

@imsky imsky closed this as completed Oct 23, 2017
@Quix0r
Copy link
Author

Quix0r commented Oct 24, 2017

Thank you. Maybe I oversaw that option. And it works here.

@imsky
Copy link
Owner

imsky commented Oct 24, 2017

sure thing @Quix0r, glad it worked out

@Quix0r
Copy link
Author

Quix0r commented Oct 26, 2017

Hmm, if I use border-size: xFOO like 5px, the border is not rendered on the rounded border corners. Maybe a general issue with CSS?

@imsky
Copy link
Owner

imsky commented Oct 26, 2017

@Quix0r i'm not 100% sure what you mean. can you post a jsfiddle with the issue?

@Quix0r
Copy link
Author

Quix0r commented Nov 2, 2017

Again signing up somewhere ... :-/ I have uploaded a screenshot to my nextcloud instance:
https://cloud.mxchange.org/index.php/s/149vSQYmDeENiuY?path=%2Fholderjs#/holderjs/20171102%20-%20Rounded%20Corner%20-%20001.png

@imsky
Copy link
Owner

imsky commented Nov 2, 2017

you can use jsfiddle without signing up @Quix0r

good point about the rounded corners - that wasn't factored into the "outline" feature. i'll file an issue to support this.

@Quix0r
Copy link
Author

Quix0r commented Nov 3, 2017

Maybe I looked too fast. Anyway. Thank you for supporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants