Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto select single folder #37

Closed
deathtrip opened this issue Jun 20, 2020 · 4 comments · Fixed by #45
Closed

auto select single folder #37

deathtrip opened this issue Jun 20, 2020 · 4 comments · Fixed by #45
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@deathtrip
Copy link

When you enter a folder and there's only one subfolder, it makes sense to automatically select it.
Maybe also consider auto selecting the biggest folder if there are many subfolders.
Because currently it takes an extra button press to select anything.

@imsnif
Copy link
Owner

imsnif commented Jun 21, 2020

Hmm... I understand what you're saying, but I'm a little concerned about auto-selection for first-time users who don't yet "get" what the marked tile is. (If it appears because you did something as a user, I think you would immediately understand what it's for).

What would you think of instead of this, when going into a folder that just has 1 tile, we would automatically go into that tile's folder directly (recursively until we get to a folder with more than 1 rectangle)? So that if I'm in:
/home/aram/ and I enter /home/aram/something which only has 1 folder called data, I would immediately get to /home/aram/something/data.

@deathtrip
Copy link
Author

Going directly to a folder with more than one rectangle could also confuse some users.

Maybe then a command line switch or config file entry, so you could control both options.
You could for example have diskonaut select the biggest tile when there are many, and if there's only one, go down the folder hierarchy.

@imsnif
Copy link
Owner

imsnif commented Jun 22, 2020

I usually like avoiding command line switches to control behaviour unless it's an extreme circumstance (eg. text-only mode or something like that).

How about if we add a "hidden" feature, wherein if you press "ENTER" and nothing is selected, the app goes into the largest folder?

@deathtrip
Copy link
Author

Seems like a good idea.

@imsnif imsnif added good first issue Good for newcomers help wanted Extra attention is needed and removed discussion labels Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants