Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When deleting files or entering folders with multibyte characters, the app might crash #54

Open
imsnif opened this issue Jun 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@imsnif
Copy link
Owner

imsnif commented Jun 26, 2020

The original issue was reported (along with a PR) here: #51
This fixes the issue for tiles on the board (the filenames in the rectangle grid), but we would also need to fix this:

error_box
title_telescope
bottom_line

  • for folders we enter and the base folder (in the title bar): src/ui/title/title_telescope.rs (I think a change here would suffice:

    current_position += truncated_cell.chars().count() as u16;
    )

  • for file display in the bottom lines: src/ui/bottom_line.rs (especially in render_currently_selected and render_last_read_path)

  • in deletion confirmation and error message boxes: src/ui/modals/error_box.rs and src/ui/modals/message_box.rs

@goto-bus-stop, I'm assigning this to you since you said you'd like to work on this when you have time. Good catch on these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant