-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new PRV segment Mapper missing after the HI segment #64
Comments
Hello, I submitted a new issue (#65) that will allow custom mapping files to be passed to the parser to accommodate specs that differ from the supported standards. We will be working on it as time is available. I believe this will help address this issue? |
Thanks for this ! |
We cannot give any real estimate, but I do not think this will happen any time soon. Simply a case of competing priorities. If you would like to submit a pull request with this feature we would gladly look into it. |
Hi @ctmay4 Could you please help us with the access to the repository to create a pull request. |
Also @ctmay4 Can we just add the mapping for the missing segment in the desired mapping file and create a pull request for the same just to suffice the requirement for now ? |
Can you supply an example (with identifiers stripped) of this segment? @angelaszek can you please comment on this? Is this part of the standard? Have we not seen this segment in any of the files we processed? |
I don't believe a PRV segment after an HI segment is standard so it's not something we want to include as part of this library. You are welcome to make this change on a local version that you maintain though. |
Hi @ctmay4 Attached is the sample file we are getting as an input. It has a PRV segment after HI segment which is currently missing in the mapper file. |
Thank you for the sample. Based on the screenshot from the ANSI 5010 X222 documentation there needs to be an NM1 segment before the PRV segment for the file to meet the standard. We don't want to make a non-standard change to the mapping file. The update to allow users to provide user-defined non-standard mappings will allow for users to process files that don't meet the standard. |
As per our inputs file we need a PRV segment mapper after our HI segment mapper in the mapping/837.5010.X222.A1.xml file. Let us know if we can add our own Mapping in the file and contribute ourselves.
Thanks,
Nikhil Javalkar
The text was updated successfully, but these errors were encountered: