Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more comprehensive tests that work with online and offline tests #9

Closed
lukpueh opened this issue Dec 19, 2018 · 1 comment · Fixed by #18
Closed

Add more comprehensive tests that work with online and offline tests #9

lukpueh opened this issue Dec 19, 2018 · 1 comment · Fixed by #18

Comments

@lukpueh
Copy link
Member

lukpueh commented Dec 19, 2018

Description of issue or feature request:
Restructure existing online and offline tests and add more comprehensive test scenarios that may be used for both.

Current behavior:
Currently there are two ways of testing the apt transport:

  1. Online test using real remote rebuilders and real debian apt and apt http transport (see tests/Dockerfile)
  2. Offline test that mocks rebuilders, apt and apt http transport (see tests/test_intoto.py)

Each currently performs one specific scenario of package installation using apt, which triggers in-toto verification with the proposed intoto transport.

Expected behavior:

  • Add more comprehensive test cases, i.e. passing/failing in-toto verification (with different combinations of configuration values).

  • Adapt online and (above all) offline test setup so that both can run the same test cases.

@lukpueh
Copy link
Member Author

lukpueh commented Jan 3, 2019

For now #18 sufficiently addresses this issue (it brings coverage with offline mock installation and unittests up to 99%).

Using the same test scenarios with online tests would be nice to have but is not a priority. We can revisit the issue if the need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant