Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache of suggested suggestions #69

Open
vkatsuba opened this issue Nov 4, 2021 · 0 comments
Open

Cache of suggested suggestions #69

vkatsuba opened this issue Nov 4, 2021 · 0 comments
Labels
discussion ⏰ Discussion feature 🚀 Feature Request improvement 💡 Improvement

Comments

@vkatsuba
Copy link
Collaborator

vkatsuba commented Nov 4, 2021

sheldon version

0.2.0

OS version

Ubuntu

Description

  • Motivation
    An incorrect 4-character word can create about +- 250 possible suggestions. In the current implementation, the generating of suggestions happens each time for any duplicates words which ultimately increases the load to system.
  • Proposal
    Add separate table for already generated suggested suggestions as for success as for empty suggestions for each word what was already checked.

Current behavior

Cache of suggested suggestions is missed.

Expected behavior

Cache of suggested suggestions is missed implemented.

Config

Optional: it might be worth considering an additional option to enable and disable the cache of suggested suggestions.

@vkatsuba vkatsuba added discussion ⏰ Discussion feature 🚀 Feature Request improvement 💡 Improvement labels Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion ⏰ Discussion feature 🚀 Feature Request improvement 💡 Improvement
Projects
None yet
Development

No branches or pull requests

1 participant