Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en strings for controlled terms (annotations) & definitions #4046

Closed
9 tasks
carrieseltzer opened this issue Mar 18, 2024 · 4 comments
Closed
9 tasks
Assignees

Comments

@carrieseltzer
Copy link
Contributor

carrieseltzer commented Mar 18, 2024

In order to improve the quality of plant phenology annotations, these en strings should be updated.

The name "plant phenology" should be updated to the more specific "flowers and fruits", and the term values changed slightly and mouseover definitions updated to clarify that the definitions are about the evidence presented rather than inference about an ongoing process on the plant.

  • Plant Phenology -> Flowers and Fruits
  • No flowers or fruits: No flowers, fruits, or seeds (in whole or part) are visible
  • Flower buds: At least one closed flower bud
  • Flowers: At least one open flower
  • Fruits or Seeds: At least one fruit or seed

A new "Leaves" controlled term should have the following terms and mouseover definitions:

  • Breaking leaf buds: At least one bud with its first new leaf or needle not fully unfolded
  • Green leaves: At least one green leaf or needle (or reddish if this is the normal healthy color)
  • Colored leaves: At least one leaf or needle has late season or drought color
  • No live leaves: No breaking leaf buds or green or colored leaves or needles are visible
@pleary pleary self-assigned this Mar 18, 2024
@pleary
Copy link
Member

pleary commented Mar 19, 2024

I'd like to point out that we'll end up with some very long strings. Our current design on the observation details page says that we don't wrap these strings, which leads to overflow issues. We'll have to add some wrapping to break up these long strings onto new lines.
Screenshot 2024-03-19 at 4 12 43 PM

@carrieseltzer
Copy link
Contributor Author

I agree about the wrapping. It doesn't look like we'll necessarily need to change anything about the way the mouseover definitions work. They're not ideal since most people don't know they're there, but that can be a separate issue if we decide to deal with it.

pleary added a commit that referenced this issue Mar 25, 2024
…cuts #4049; remove unused controlled term form fields #4050
@carrieseltzer
Copy link
Contributor Author

I just updated the ticket with clarified terms, values, and definitions.

@carrieseltzer
Copy link
Contributor Author

Slightly updated leaf definitions. Let me know if it's helpful for me to add them to production.

pleary added a commit that referenced this issue Jun 4, 2024
@pleary pleary closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants