Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm install #184

Closed
peterdesmet opened this issue Apr 4, 2023 · 3 comments
Closed

Fix npm install #184

peterdesmet opened this issue Apr 4, 2023 · 3 comments
Assignees
Milestone

Comments

@peterdesmet
Copy link
Member

peterdesmet commented Apr 4, 2023

Trying to install crow locally with npm install results in errors:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @vue/cli-plugin-eslint@5.0.8
npm ERR! Found: eslint@6.8.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^6.8.0" from the root project
npm ERR!   peer eslint@"^5.0.0 || ^6.0.0 || ^7.0.0" from @typescript-eslint/eslint-plugin@4.33.0
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     dev @typescript-eslint/eslint-plugin@"^4.33.0" from the root project
npm ERR!     peer @typescript-eslint/eslint-plugin@"^4.4.0" from @vue/eslint-config-typescript@7.0.0
npm ERR!     node_modules/@vue/eslint-config-typescript
npm ERR!       dev @vue/eslint-config-typescript@"^7.0.0" from the root project
npm ERR!   8 more (@typescript-eslint/experimental-utils, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@">=7.5.0" from @vue/cli-plugin-eslint@5.0.8
npm ERR! node_modules/@vue/cli-plugin-eslint
npm ERR!   dev @vue/cli-plugin-eslint@"^5.0.8" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint@8.37.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@">=7.5.0" from @vue/cli-plugin-eslint@5.0.8
npm ERR!   node_modules/@vue/cli-plugin-eslint
npm ERR!     dev @vue/cli-plugin-eslint@"^5.0.8" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 

This looks similar to #163 and may be caused by some npm install <package> --force that break the dependency tree. Maybe we should start from a empty package-lock.json and see if we can build a clean dependency tree.

In addition to fixing this, we could try to update some dependencies.

@peterdesmet peterdesmet self-assigned this Apr 4, 2023
@peterdesmet peterdesmet changed the title Update dependencies Fix npm install Apr 4, 2023
@peterdesmet
Copy link
Member Author

@niconoe any insight into this would be highly appreciated. 😄

@peterdesmet
Copy link
Member Author

peterdesmet commented Apr 4, 2023

Steps taken:

  1. Remove package-lock.json
  2. Remove node_modules
  3. Run npm cache clean --force
  4. Run npm install

This works and indicates:

added 2510 packages, and audited 2511 packages in 2m

169 packages are looking for funding
  run `npm fund` for details

47 vulnerabilities (1 low, 10 moderate, 31 high, 5 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

But this breaks npm run serve and npm run test:unit

@peterdesmet
Copy link
Member Author

Fixed in #187

@peterdesmet peterdesmet added this to the Aloft milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant