-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bioRad density colour scale #38
Comments
@peterdesmet: since the R code is not immediately obvious to me, I have two questions:
Don't worry if you can't easily answer, I'll dig deeper into the R implementation. |
Update: we got details by e-mail, copying here for future references:
|
Check the correctness of scale and colours |
I've done some work regarding this colour scale, but also updated related/interleaved matters at the same time. I'm relatively happy with the result I have to admit I'm not 100% comfortable with the the pure science/data-related behind, so I'd like to explain what I did so I can have other pair of eyes looking at both the end result (https://inbo.github.io/crow/#/) and my explanations:
|
The bioRad colour scale in our plots is off compared to the bioRad package, see #45 (comment) |
See #45 (comment) for the current state on this issue: there is a slight colour difference caused by real log vs sym log and pushing very small values to 0.5. We could try to get it closer, but it has low priority. |
The density colour scale in bioRad for height profiles is defined here: https://github.com/adokter/bioRad/blob/e0ede427eb34007dc9985302d40cbdab158e0636/R/color_scale.R#L65-L85
The resulting 256 values are:
The text was updated successfully, but these errors were encountered: