Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a package out of download_zenodo() and publish it under rOpenSci #71

Closed
damianooldoni opened this issue Jan 28, 2020 · 7 comments
Closed
Labels

Comments

@damianooldoni
Copy link
Member

The function download_zenodo() seems something very interesting and it can have a very broad audience.
While following the discussion in #69, I am happy to see that this function is getting more and more complete but also complex (= more dependencies).
Broad scope + completeness + complexity = package 📦

Especially if I see that there is a package called zenodo to upload data to zenodo and whose documentation is published under the hood of rOpenSci. However the package is quite old, probably not actively maintained anymore and that it is not listed among the rOpenSci packages.
@inbo/bmk , @inbo/oscibio: what do you think about it?

@peterdesmet
Copy link
Member

I would be all for that. We could even reach out to rOpenSci to see if we can take over pkg maintenance.

@florisvdh
Copy link
Member

florisvdh commented Jan 29, 2020

I fully agree. Would love not to have to depend on inborutils in more focused packages ;-)

I believe complexity is an unavoidable downside of collecting various different functions in one package (inborutils) - which however should be seen as its 'purpose' somehow: a collection of small new ideas. (Is also a reason why I'm not that worried about having extra dependencies in inborutils @ThierryO ;-) )

@hansvancalster
Copy link
Contributor

I ran a search and found zen4R to be interesting as well. Both zen4R and zenodo provide functionalities that interact with the Zenodo REST API. The function download_zenodo() on the other hand does not do that. It just downloads the data from a zenodo doi. It's not that clear from the documentation of the Zenodo REST API if downloading of files is already possible (I think not).

@florisvdh
Copy link
Member

It seems that zen4R is more recent and has more functionality; it could also be a good candidate for the function. It seems not to be published at rOpenSci.

I think we should reach out to the developers of both packages and to rOpenSci to initiate that discussion (could be done from and in this thread).

@hansvancalster
Copy link
Contributor

See eblondel/zen4R#31

@hansvancalster
Copy link
Contributor

The function is now (also) part of the zen4R package. See https://cran.r-project.org/web/packages/zen4R/zen4R.pdf and search for download_zenodo. This issue can be closed. Thanks for asking @damianooldoni 👍

@florisvdh
Copy link
Member

The function is now (also) part of the zen4R package

Just note that both functions are fundamentally different. If I remember correctly the zen4R function is a complete rewrite that sends a request to the Zenodo API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants