Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side methods for setting and getting room data. #39

Closed
aychtang opened this issue Oct 29, 2013 · 3 comments
Closed

Client side methods for setting and getting room data. #39

aychtang opened this issue Oct 29, 2013 · 3 comments

Comments

@aychtang
Copy link
Collaborator

There is still a bit of work to hook up getting and setting of a users current rooms state or data (The latest test I added may be the quickest way and requires defining a getter and setter on the server config I think we should give for free). What are your thoughts on exposing methods that abstract that work away from the user.

@aychtang
Copy link
Collaborator Author

Side note: I think user should be the first arg to server messages handlers, with data as an optional arg, to allow for sending messages without data easier.

@incompl
Copy link
Owner

incompl commented Oct 30, 2013

Will not add this: room data should be able to contain secrets that the client may not be privy to. Revelation of game state should go through messages.

user is the second argument to keep the client / server consistent, with data being the first argument, and additional situation-specific arguments coming after that.

@incompl incompl closed this as completed Oct 30, 2013
@incompl
Copy link
Owner

incompl commented Oct 31, 2013

See #40 for further discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants