config.lobby.newMember invoked before config.clientEvents.begin?

[gamecubate]

Looking at the sequence of server side events, it seems like lobby.newMember gets called before clientEvents.begin (newly connected user) does. This doesn't make sense to me but I'll work with it if that is indeed the way things are. Can you confirm? Thanks.

[incompl]

Yup looks like it: https://github.com/incompl/cloak/blob/master/src/server/cloak/index.js#L133-L138

I could see the case for swapping those in a new version. What do you think, @jugglinmike?

[gamecubate]

To clarify, this is obviously not a deal breaker but I was thrown off by the fact that one could be seen as entering a room (newMember) before one had established a first handshake with the server (begin). Hence my post. I could do a PR if you want.

[vstirbu]

The begin, disconnect and resumeclient events are related to the connectivity layer (e.g. web sockets), while the newMember is an application level concept (e.g room/lobby).

Maybe the documentation needs to be updated to make the distinction clearer.

[incompl]

@gamecubate I'd be happy to look at a PR for that!

[gamecubate]

Well, judging from @vstirbu's answer, this seems normal. I wouldn't want to rock the boat for so trivial a matter. Will close issue for now.