Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punctuation not visible #123

Closed
jedbt opened this issue Sep 15, 2015 · 9 comments
Closed

punctuation not visible #123

jedbt opened this issue Sep 15, 2015 · 9 comments

Comments

@jedbt
Copy link

jedbt commented Sep 15, 2015

CSS code samples don't show punctuation marks { : ; } on screen

@bdaley
Copy link

bdaley commented Sep 16, 2015

+1

Missing background color?

@jedbt
Copy link
Author

jedbt commented Sep 16, 2015

Backgrounds off fixes it for print preview, still missing on screen

leobalter added a commit to leobalter/csslayoutsite that referenced this issue Sep 16, 2015
Fixes incompl#123

pygments got updated in the go on easy_install/pip to version 2 and
now uses class="language-html" instead of class="html", the same
for css syntax.
@leobalter
Copy link
Contributor

It was an update on pygments breaking retrocompatibility.

After this is solved it is good to specify a pygments version or change it to a package version we can control.

@incompl
Copy link
Owner

incompl commented Sep 21, 2015

I fixed the issue by rebuilding and redeploying the site with my current system.

I then updated my system from Pygments 1.6 to Pygments 2.0.2, without merging the current PR for fixing this issue. This does not cause the site to build incorrectly. @leobalter, do you know what version of Pygments had the issue addressed in #124?

@leobalter
Copy link
Contributor

I used Pygments 2.0.2.

Maybe I am wrong this is related to pygments, but to other dependency.

I keep building it with the prefixed classes names.

@incompl
Copy link
Owner

incompl commented Sep 21, 2015

Interesting. It must be another dependency. My Jekyll version is 2.0.3, what about yours?

@leobalter
Copy link
Contributor

I'll need to confirm that tomorrow at the computer I used.

On Mon, Sep 21, 2015 at 5:39 PM, Greg notifications@github.com wrote:

Interesting. It must be another dependency. My Jekyll version is 2.0.3,
what about yours?


Reply to this email directly or view it on GitHub
#123 (comment)
.

@leobalter
Copy link
Contributor

I've found it => jekyll/jekyll#2511 and https://github.com/jekyll/jekyll/releases/tag/v2.1.0

It was a breaking change on a minor version. :/

@incompl
Copy link
Owner

incompl commented Nov 24, 2015

Fixed now, plus last-tested dependency versions added to README

@incompl incompl closed this as completed Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants