Making highlight behave more like redcarpet

[denilsonsa]

See issue #2510 for details.

Note: redcarpet does not escape the class name (like Jekyll does).

This means that c++ in redcarpet generates class="language-c++", while in Jekyll will be c--. Should I also remove this gsub("+", "-") call, so that both generate the same code? And why is it here anyway?

[parkr]

LGTM!

[parkr]

@mattr- / @benbalter ?

[denilsonsa]

@parkr Nobody answered me about that gsub call in the code. But it is okay, it is not very important. (The issue fixed by this pull request was much worse, thanks for merging it!)

[parkr]

Sorry! It looked fine to me (c++ would be tranformed into c--). + is a special char in CSS?

[denilsonsa]

According to this StackOverflow question, essentially all non-whitespace chars are valid (they might just need escaping).

It just seemed odd to me to explicity change + to - in that code, with no comment to why it is needed. After all, why change + from c++ but not change # from c#? (BTW, both have alternative names: cpp and csharp.)

In my opinion, I believe it is best for the users if both Jekyll and redcarpet agree on the output. Either both of them escape/replace equally, or none of them do it. For simplicity, I'd stick to the later.

Your call. :)

(BTW, you may also want to close #2510.)

[leobalter]

Not that having changed class names from html to language-html represented a breaking change. I understand the examples with c and c++ are enough arguments for this change but it would be easier to identify this change in a major version, in case you're using a semver standard.

Nothing to fix after for this comment but I ask to avoid breaking retrocompatibility on minor versions next time to prevent a time investigating what happened.

[parkr]

@leobalter We do our best.

[leobalter]

Sure, and Jekyll is a great tool! I'm sorry if was tough.